[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Oh, the horror of monstrously broken tests...

From: Branko Čibej <brane_at_xbc.nu>
Date: 2003-11-19 19:30:43 CET

C. Michael Pilato wrote:

>Branko Čibej <brane@xbc.nu> writes:
>
>
>
>>I just noticed something fairly horrible. In many places in our test
>>suite, we don't check the stderr output from 'svn', which means that
>>failed tests aren't always detected. For example, all the autoprop tests
>>fail on Windows (because someone used os.path.join to construct a
>>URL...pelople never learn), but only three were tagged as failed.
>>
>>This is serious. The easiest solution would be for
>>svntest.main.run_command to raise an exception if the stderr output
>>isn't empty when no error is expected.
>>
>>Other suggestions welcome.
>>
>>
>
>I have only one suggestion -- *please* fix this now, if you have time,
>and in whatever way you see fit. You know the test suite at least as
>well as, and perhaps better than, anyone else.
>
>
We can hope. :-)

I meant to commit the fix yesterday, but I couldn't run the tests
because svn crashes for me on Windows. It looks like there's an
out-of-bounds index somewhere in the skels (or perhaps the
representations?) code; I haven't been able to track it down yet, even
with Purify.

Mike, I think you made changes in that code since the 0.33 branch was
cut; is it possible something slipped past you? (Note that I'm not
pointing any fingers here.)

>And (my opinion here) if fixing the test suite means tests start
>failing, don't worry about fixing those tests before committing. I
>can't speak for others, but XFAILs don't speak as loudly to me from a
>motivational standpoint as do FAILs. :-)
>
>
Oh, yes.

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Nov 19 19:29:28 2003

This is an archived mail posted to the Subversion Dev mailing list.