Re: Oh, the horror of monstrously broken tests...

Julian Foad wrote:

> Branko Čibej wrote:
>
>> I just noticed something fairly horrible. In many places in our test
>> suite, we don't check the stderr output from 'svn', which means that
>> failed tests aren't always detected. For example, all the autoprop tests
>> fail on Windows (because someone used os.path.join to construct a
>> URL...pelople never learn), but only three were tagged as failed.
>>
>> This is serious. The easiest solution would be for
>> svntest.main.run_command to raise an exception if the stderr output
>> isn't empty when no error is expected.
>>
>> Other suggestions welcome.
>
>
> I think that is a good solution. run_command doesn't presently
> document whether unexpected stderr is considered an error, but I think
> that would be a sensible behaviour. I have just tried it and the
> following correction is needed to an existing test (it was only a
> warning, and ignoring it didn't affect the validity of the test):

Thanks, I'll add that change to the patch waiting in my tree.

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org