[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Oh, the horror of monstrously broken tests...

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: 2003-11-19 06:32:34 CET

Branko Čibej <brane@xbc.nu> writes:

> I just noticed something fairly horrible. In many places in our test
> suite, we don't check the stderr output from 'svn', which means that
> failed tests aren't always detected. For example, all the autoprop tests
> fail on Windows (because someone used os.path.join to construct a
> URL...pelople never learn), but only three were tagged as failed.
>
> This is serious. The easiest solution would be for
> svntest.main.run_command to raise an exception if the stderr output
> isn't empty when no error is expected.
>
> Other suggestions welcome.

I have only one suggestion -- *please* fix this now, if you have time,
and in whatever way you see fit. You know the test suite at least as
well as, and perhaps better than, anyone else.

And (my opinion here) if fixing the test suite means tests start
failing, don't worry about fixing those tests before committing. I
can't speak for others, but XFAILs don't speak as loudly to me from a
motivational standpoint as do FAILs. :-)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Nov 19 06:33:43 2003

This is an archived mail posted to the Subversion Dev mailing list.