Branko Čibej wrote:
>>@@ -99,73 +107,136 @@
>> myhash[20:32]))
>> return guid
>>
>>+ def move_proj_file(self, path, name):
>>+ dest_file = os.path.join( path, name )
>>+ if not os.path.exists(dest_file):
>>+ source_file = os.path.join( 'build', 'win32', name )
>>+ print 'Copying', dest_file
>>+ print ' from', source_file
>>+ self.copyfile(dest_file, source_file)
>>
>
> I'd suggest using write_file_if_changed instead of copyfile, for the
> same reason its used for writing the other project files.
>
Hmm, I was only copying the files over if they didn't exist on the
assumption that apr might include or generate them someday, or the user
converted a newer version of apr already, or whatever, and I didn't want
to whack what they had already and possibly break their build (ie, a
newer apr adds a new source file that is not in the apr.vcproj.in file).
Do you think that is too cautious and it should just use
write_file_if_changed?
DJ
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jun 20 03:19:31 2003