I'd install this patch, since it can't break anything that's not broken
yet :-) but I have a few comments.
A couple of general notes:
* I suggest renaming the .vcproj files that get copied to apr to
.vcproj.in and renaming them on copy, to avoid any confusion.
* It looks like the dependency tweaks in Generator.write are 99%
identical to the ones in gen_msvc_dsp.py. It would be nice to
factor those into gen_win.py.
[snip]
>@@ -50,15 +56,15 @@
> libs=self.get_win_libs(target, cfg),
> ))
>
>+
> sources = [ ]
> for src, reldir in self.get_win_sources(target):
>- rsrc = string.replace(string.replace(src, target.path + os.sep, ''),
>- os.sep, '\\')
>- sources.append(rsrc)
>-
>- # sort for output stability, to watch for regressions
>- sources.sort()
>-
>+ rsrc = string.replace(os.path.join(rootpath, src), os.sep, '\\')
>+ if '-' in rsrc:
>+ rsrc = '%s' % rsrc
>
I don't get the point of this; bit; is rsrc changed in any way?
[snip]
>@@ -99,73 +107,136 @@
> myhash[20:32]))
> return guid
>
>+ def move_proj_file(self, path, name):
>+ dest_file = os.path.join( path, name )
>+ if not os.path.exists(dest_file):
>+ source_file = os.path.join( 'build', 'win32', name )
>+ print 'Copying', dest_file
>+ print ' from', source_file
>+ self.copyfile(dest_file, source_file)
>
I'd suggest using write_file_if_changed instead of copyfile, for the
same reason its used for writing the other project files.
Oh, and please lose the spaces after the parens, eek.
--
Brane Čibej <brane_at_xbc.nu> http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jun 17 01:08:37 2003