[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: core dump with svn r6178

From: Greg Stein <gstein_at_lyra.org>
Date: 2003-06-20 03:22:45 CEST

On Fri, Jun 20, 2003 at 12:34:44AM +0200, Sander Striker wrote:
> > mean, if you have a Subversion server that's sending your client a
> > bogus REPORT response, by golly we want to know about it.
> In any case, we should not segfault on it. It is bad mojo if the server
> can let the client crash (or the other way around) by bad data.

Well, yah. That is an entirely different situation. We're talking about
functions being passed bad parameters. If the system gets bad *data* from
somewhere, then yup: we should gracefully error.

Thus, the ### comments in that parsing code. But that is about the parsing
out of the data. If we pass NULL to svn_string_FOO, then those ought
segfault before you can say "who's your daddy!?!"


Greg Stein, http://www.lyra.org/
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jun 20 03:18:34 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.