[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Windows vcproj generator

From: Branko Čibej <brane_at_xbc.nu>
Date: 2003-06-20 03:22:32 CEST

D.J. Heap wrote:

> Branko Čibej wrote:
>>> @@ -99,73 +107,136 @@
>>> myhash[20:32]))
>>> return guid
>>> + def move_proj_file(self, path, name):
>>> + dest_file = os.path.join( path, name )
>>> + if not os.path.exists(dest_file):
>>> + source_file = os.path.join( 'build', 'win32', name )
>>> + print 'Copying', dest_file
>>> + print ' from', source_file
>>> + self.copyfile(dest_file, source_file)
>> I'd suggest using write_file_if_changed instead of copyfile, for the
>> same reason its used for writing the other project files.
> Hmm, I was only copying the files over if they didn't exist on the
> assumption that apr might include or generate them someday, or the
> user converted a newer version of apr already, or whatever, and I
> didn't want to whack what they had already and possibly break their
> build (ie, a newer apr adds a new source file that is not in the
> apr.vcproj.in file). Do you think that is too cautious and it should
> just use write_file_if_changed?

Yeah. If APR ever includes .vcproj files, we'll just remove ours, It's
not as if we have to support old versions of APR.

Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jun 20 03:23:30 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.