Re: [PATCH] Windows vcproj generator

Thanks for the review, those are very good points, of course. I will
re-factor and cleanup when I have some time -- probably this weekendish.

DJ

Branko Čibej wrote:
> I'd install this patch, since it can't break anything that's not broken
> yet :-) but I have a few comments.
>
> A couple of general notes:
>
> * I suggest renaming the .vcproj files that get copied to apr to
> .vcproj.in and renaming them on copy, to avoid any confusion.
> * It looks like the dependency tweaks in Generator.write are 99%
> identical to the ones in gen_msvc_dsp.py. It would be nice to
> factor those into gen_win.py.
>
>

[snip]

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jun 17 03:31:34 2003