Re: Tests

"D.J. Heap" <djheap@dhiprovo.com> writes:

>>There was a testsuite race in past (copying a repository while
>>svnserve was still accessing it), but I see you are running over
>>ra_local and commit test 21 is simple: add a file, commit, update,
>>commit.

Oops, I misread your original message. I see now it's test 22 that
fails, not test 21. Hmm, test 22 does

   was_dir = os.getcwd()
   os.chdir(...)
   if svntest.actions.run_and_verify_commit(...)
     os.chdir(was_dir)
     return 1
   os.chdir(was_dir)

If the commit raises an exception then the chdir(was_dir) will not
occur, which in turn will cause the second failure you see and means
that all the later commit tests will not get run.

This test, and possibly others that use chdir, may need to be
converted to use try: finally:, or possibly the driver should ensure
that the current working directory gets reset.

> Yes, it could be another symptom of the filesystem race, I suppose. I
> haven't looked closely at the working copy and repo, but status and log
> commands work fine and show that the commit seemed to work fine. It
> would help if I understood better what the test failure was saying -- is
> it the working copy that does not match what was expected or is it the
> output from stdout or something else?

I think the failure indicates that the commit command output contained
a full path

  C:\some\path\to\iota

while the test expected the output to have a path like

  iota

I don't understand why the error is intermittent, I would expect it to
occur every time, or not at all.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org