Re: [patch] ask for username if getting UID fails

SteveKing wrote:

>Sure it's a serious error. But not a reason why subversion should error out.
>
Eh? You lost me there.

>Subversion can, even if the UID can't be retreived, just _ask_ for a
>username and proceed. That's what I'm trying to do with the patch.
>
I understand what you're trying to do, and I don't agree. I believe we
should report serious errors. Not being able to get the UID is a serious
error on all the systems I know, _except_ Win9x (when not logged into an
NT domain). So the seriousness of the error is a platform-specific
issue, and should be handled by APR.

>I'm not trying anything with caching or changing anything else about the
>whole authentication. Just make subversion _ask_ for a username if
>it can't get one from the system.
>
No, not "if it can't get one from the sytem"; rather, "if the system
does not provide one". These cases aren't the same. Hence my proposal to
teach APR to detect this case, then change your patch to not report the
error _only_ if APR says the system doesn't have that concept, _not_ if
APR says it can't retrieve the user ID even if the system _does_ have
that concept.

>I know you're trying to explain me something but I just don't get it. I
>still can't see why my patch (or what I'm trying to do with it) is bad.
>
I don't think what you're trying to do is bad, but your change is too
general. It should be narrowed down to just those systems which don't
have the concept of a user ID.

I'll concede that username caching is a separate issue.

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org