----- Original Message ----- > >
> I have taken a look at your patch, and I think it's wrong. Consider what
> happens if you can't get the current UID on Unix. Currently, svn errors
> out -- correctly. On Unix, that's a serious error. With your patch, that
> error would be hidden.
Sure it's a serious error. But not a reason why subversion should error out.
Subversion can, even if the UID can't be retreived, just _ask_ for a
username
and proceed. That's what I'm trying to do with the patch.
I'm not trying anything with caching or changing anything else about the
whole authentication. Just make subversion _ask_ for a username if
it can't get one from the system.
I know you're trying to explain me something but I just don't get it. I
still
can't see why my patch (or what I'm trying to do with it) is bad.
> A potentially correct patch would be to fix apr_uid_current to return a
> well-known error code on Win98 if it couldn't get the UID; then this
> code could be conditionalized based on that return code.
That would be necessary if there are multiple occasions where
apr_uid_current()
could break. But right now I can't see _any_ reason which would force
subversion to error out. Whatever makes apr_uid_current() fail won't
prevent subversion to ask for a username instead.
Maybe I'm not clear enough about what I'm trying to do. I'll try to
explain better:
- the user doesn't pass --username
- subversion detects that authentication is necessary
- subversion tries first to get a default username with apr_uid_current()
- apr_uid_current() fails, subversion exits.
--- or
- apr_uid_current() succeeds,
---- now subversion has a username
- subversion asks for a password
- authentication fails (e.g. the default username is wrong)
- subversion _now_ asks for a username, then for a password
now I want to change that to:
- the user doesn't pass --username
- subversion detects that authentication is necessary
- subversion tries first to get a default username with apr_uid_current()
- apr_uid_current() fails, subversion asks for a username
---- now subversion has a username
- proceed as above
I really don't wanna mess around with creds, saving/storing/caching
those or change something else.
It's like "if getting the UID fails, try getting it by asking the user".
Stefan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu May 15 22:23:31 2003