[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [patch] ask for username if getting UID fails

From: Greg Hudson <ghudson_at_MIT.EDU>
Date: 2003-05-16 06:20:13 CEST

On Thu, 2003-05-15 at 15:57, Branko ╚ibej wrote:
> I have taken a look at your patch, and I think it's wrong. Consider what
> happens if you can't get the current UID on Unix. Currently, svn errors
> out -- correctly. On Unix, that's a serious error. With your patch, that
> error would be hidden.

getuid() will never fail on Unix. So worrying about that case is a dumb
reason to object to this patch. If by some weird offchance it ever does
happen, there's no reason Subversion should take responsibility for
reporting it to the user.

getpwuid() of the result could fail. That's an error, but not a
terribly serious one. Again, there's no reason Subversion shouldn't
fall back to asking for a username in this case; we are a version
control system, not a system diagnostic tool.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri May 16 06:21:09 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.