Re: [patch] ask for username if getting UID fails

SteveKing wrote:

>pass --username is a wonderful option. But not all clients implement
>that. You're talking here about the command line client but there
>are other clients too.
>
Other clients pass the username directly to the API. Your patch isn't
going to help them.

>Please have a look at my patch. It's only a few lines long and
>you'll understand better what I'm trying to do here.
>
>
I have taken a look at your patch, and I think it's wrong. Consider what
happens if you can't get the current UID on Unix. Currently, svn errors
out -- correctly. On Unix, that's a serious error. With your patch, that
error would be hidden.

A potentially correct patch would be to fix apr_uid_current to return a
well-known error code on Win98 if it couldn't get the UID; then this
code could be conditionalized based on that return code.

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org