[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 4685 - in trunk/subversion: include libsvn_wc libsvn_client libsvn_auth

From: mark benedetto king <mbk_at_boredom.org>
Date: 2003-01-31 14:00:01 CET

On Fri, Jan 31, 2003 at 09:44:01AM +0100, Sander Striker wrote:
> > From: cmpilato@tigris.org [mailto:cmpilato@tigris.org]
> > Sent: Friday, January 31, 2003 9:13 AM
>
> > Author: cmpilato
> > Date: 2003-01-31 02:12:13 -0600 (Fri, 31 Jan 2003)
> > New Revision: 4685
> >
> > Modified:
> > trunk/subversion/include/svn_error_codes.h
> > trunk/subversion/libsvn_auth/auth.c
> > trunk/subversion/libsvn_client/auth.c
> > trunk/subversion/libsvn_wc/simple_wc_provider.c
> > Log:
> > More issue #724 - Some fixes, and now only try to save using the
> > provider that supplied the creds.
>
> Huh? I really don't get this. A simple prompting provider won't
> be able to save creds, so if a passwd is not in a cache it has no
> chance of ever getting in? My take on this was try the provider
> you got the creds from first, if that fails cycle over all others.
>

What if, instead, the functions looked something like

  svn_error_t * (*first_credentials) (void **credentials,
                                      void **iter_baton,
                                      void *provider_baton,
                                      svn_boolean_t *private,
                                      apr_pool_t *pool);

where "private" would be set to indicate that the credentials
supplied MUST NOT be disclosed to other providers.

Then, the simple prompting provider can control this behaviour on its
own.

--ben

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jan 31 14:00:57 2003

This is an archived mail posted to the Subversion Dev mailing list.