[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 4685 - in trunk/subversion: include libsvn_wc libsvn_client libsvn_auth

From: <cmpilato_at_collab.net>
Date: 2003-01-31 10:11:53 CET

"Sander Striker" <striker@apache.org> writes:

> > Our simple prompting provider can, because it uses the same
> > auth-storing function that the WC-cache-reading provider uses.
>
> Ewww. This seems to defeat the whole purpose of the pluggable
> provider API. Guess what happens if I want to use, say, an
> svn-agent provider and a prompting provider? Now I have to either
> reimplement prompting in the svn-agent provider, or, implement
> a seperate prompting provider (can't reuse the svn prompting
> provider since it will write my creds to disk(!)).
>
> > > This can be done in the phase where we register the providers. If
> > > --no-auth-cache is present, simply not register the provider that
> > > gets/sets the user/pass in the working copy. And do register it
> > > if store-password is present.
> >
> > I think WC auth-reading provider should be registered even if
> > 'store-password' is "no".
>
> Then just split the wc auth provider in a read and write provider.
> Only register the write if you are allowed to cache on disk in the
> wc.
>
> > Just because the user no longer wants us to
> > store his password doesn't mean it isn't already in the cache. :-)
>
> True.

Okay, now your complaints have surpassed my level of understanding and
goal of the auth system. (All these changes I've made today have just
been me being Ben's extra set of eyes and hands.) I'm gonna abstain
from further comment until Ben can register his thoughts.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jan 31 10:15:02 2003

This is an archived mail posted to the Subversion Dev mailing list.