Re: [PATCH] enum svn_node_kind -> svn_node_kind_t

Daniel Rall <dlr@finemaltcoding.com> writes:
> It compiles successfully. I just tried `make check` and all tests
> passed. However, it seems that both myself and the folks on #svn were
> surprised that merge_tests-4/A/B2 spawned a new xemacs window -- it it
> wanted a commit log message. :-\ Once I provided the message,
> merge_tests.py moved on, completing successfully. The feeling is that
> automated tests shouldn't require manual intervention.

No argument there! It's a bug in the test, I'll take a look.

> Regarding committing, I'd be happy to. I'll point out that I'm only
> okayed commit for the bindings sub-tree, but since explicit permission
> was given, I'll commit anyhow to cut down on overhead unless some
> takes issue with this and speaks up. :)

This way is always okay -- it effectively means that the person who
said "commit that baby" is vouching for the change. (And in practice,
it's not like anyone would flip out if the commit caused a problem,
we'd just fix it).

-K

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Nov 4 22:53:42 2002