Re: [PATCH] enum svn_node_kind -> svn_node_kind_t

Karl Fogel <kfogel@newton.ch.collab.net> writes:

> Daniel Rall <dlr@finemaltcoding.com> writes:
> > It compiles successfully. I just tried `make check` and all tests
> > passed. However, it seems that both myself and the folks on #svn were
> > surprised that merge_tests-4/A/B2 spawned a new xemacs window -- it it
> > wanted a commit log message. :-\ Once I provided the message,
> > merge_tests.py moved on, completing successfully. The feeling is that
> > automated tests shouldn't require manual intervention.
>
> No argument there! It's a bug in the test, I'll take a look.
>
> > Regarding committing, I'd be happy to. I'll point out that I'm only
> > okayed commit for the bindings sub-tree, but since explicit permission
> > was given, I'll commit anyhow to cut down on overhead unless some
> > takes issue with this and speaks up. :)
>
> This way is always okay -- it effectively means that the person who
> said "commit that baby" is vouching for the change. (And in practice,
> it's not like anyone would flip out if the commit caused a problem,
> we'd just fix it).

Gotcha. Committed as rev 3647. Had a slight log message snafu, fixed
now.

-- 
Daniel Rall <dlr@finemaltcoding.com>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org