Re: [PATCH] enum svn_node_kind -> svn_node_kind_t

Karl Fogel <kfogel@newton.ch.collab.net> writes:

> Daniel Rall <dlr@finemaltcoding.com> writes:
> > I tend to use typedefs in preference to struct/enum/union/etc. decls
> > myself. Looks like Mike intended a conversion after adding the
> > typedef. Here's the patch:
> >
> > * Conversion of enum svn_node_kind to the newer svn_node_kind_t
> > typedef.
>
> This looks pretty straightforward to me. Daniel, assuming it compiles
> and passes 'make check' (I mean, of course it does, but my natural
> paranoia kicks in), I'd say go ahead and commit it.

It compiles successfully. I just tried `make check` and all tests
passed. However, it seems that both myself and the folks on #svn were
surprised that merge_tests-4/A/B2 spawned a new xemacs window -- it it
wanted a commit log message. :-\ Once I provided the message,
merge_tests.py moved on, completing successfully. The feeling is that
automated tests shouldn't require manual intervention.

Regarding committing, I'd be happy to. I'll point out that I'm only
okayed commit for the bindings sub-tree, but since explicit permission
was given, I'll commit anyhow to cut down on overhead unless some
takes issue with this and speaks up. :)

-- 
Daniel Rall <dlr@finemaltcoding.com>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org