Why not use the "svn_node_kind_t" typedef instead of "enum
svn_node_kind" from subversion/include/svn_types.h? Curious what the
style preference is.
- Dan
rooneg@tigris.org writes:
> Author: rooneg
> Date: 2002-11-03 16:58:53 -0600 (Sun, 03 Nov 2002)
> New Revision: 3629
>
> Modified:
> trunk/subversion/libsvn_wc/adm_files.c
> trunk/subversion/libsvn_wc/adm_files.h
> Log:
> clarify the types for svn_wc__make_adm_thing. what's the point of having an
> enum if you pass it around as an int?
>
> * subversion/libsvn_wc/adm_files.h
> (svn_wc__make_adm_thing): change the type of TYPE from an int to an
> svn_node_kind, since that's what it is anyway.
>
> * subversion/libsvn_wc/adm_files.c
> (svn_wc__make_adm_thing): ditto. also, add a space between a function name
> and it's paren to be consistent with the rest of the file.
>
> Modified: trunk/subversion/libsvn_wc/adm_files.c
> ==============================================================================
> --- trunk/subversion/libsvn_wc/adm_files.c (original)
> +++ trunk/subversion/libsvn_wc/adm_files.c Sun Nov 3 16:59:02 2002
> @@ -167,7 +167,7 @@
> svn_error_t *
> svn_wc__make_adm_thing (svn_wc_adm_access_t *adm_access,
> const char *thing,
> - int type,
> + enum svn_node_kind type,
> apr_fileperms_t perms,
> svn_boolean_t tmp,
> apr_pool_t *pool)
> @@ -179,7 +179,7 @@
>
> SVN_ERR (svn_wc_adm_write_check (adm_access));
>
> - path = extend_with_adm_name (svn_wc_adm_access_path(adm_access),
> + path = extend_with_adm_name (svn_wc_adm_access_path (adm_access),
> NULL, tmp, pool, thing, NULL);
>
> if (type == svn_node_file)
>
> Modified: trunk/subversion/libsvn_wc/adm_files.h
> ==============================================================================
> --- trunk/subversion/libsvn_wc/adm_files.h (original)
> +++ trunk/subversion/libsvn_wc/adm_files.h Sun Nov 3 16:59:04 2002
> @@ -55,7 +55,7 @@
> /* Make `PATH/<adminstrative_subdir>/THING'. */
> svn_error_t *svn_wc__make_adm_thing (svn_wc_adm_access_t *adm_access,
> const char *thing,
> - int type,
> + enum svn_node_kind type,
> apr_fileperms_t perms,
> svn_boolean_t tmp,
> apr_pool_t *pool);
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Nov 4 21:05:43 2002