[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: patch suggestion

From: Ich Selbst <ichselbst_at_gmx.ch>
Date: 2002-11-04 20:47:16 CET

>
> Bah.

Gesundheit

> > - I just think it better if someone
> >uses
> >several clients that each client can make its own settings - maybe a
client
> >wants to use a different diff/diff3 version than another client
> >
> What's the benefit here?
1. testing diff programs with new filetypes
2. using non gnu diff programs (i.e. they use slightly different parameters
for calling) and
   the client 'translates'
3. using other proxy settings for different clients could also be usefull
for testing

> > or the
> >client
> >has a built-in diff/diff3 or ...
> >
> In that case, you won't be able to use the svn_client_diff API at all.
why not? If it follows the same calling conventions?

> It's not a really small change, and your change is wrong because it
> totally ignores config files. Besides, making this a compile-time
> options means that different clients wouldn't be able to share the same
> Subversion libraries. Yuck.
as far as I could see the config files are still used - if not then why even
implement using the registry?
And I really think that different clients should use also different
subversion
libraries and not be forced to use the same! Imagine one day Subversion
is improved to a point where backward compatibility is not fully possible -
then you MUST be able to use different clients with different subversion
libraries (one for older repos, one for the new ones).
And besides: right now its only possible to link directly to subversion so
each client HAS a different subversion library built in.

> If you want that level of configurability, I suggest designing
> client.side hooks/callbacks. But the first step is to finally implement
> some kind of context from which the library functios can pull
> configuration settings, instead of every function parsing the config all
> over again.
no offense - but I think my patch is usefull anyway. Since you're not
forced to use it - either use it (by specifying the define in the compiler)
or
use the default (the way it is now).

Another thought: If a client/user uses the registry for storing config data
then the settings for the same program (the client) will be on different
base paths: the one for subversion under Software\tigris.org\subversion and
the rest under Software\ClientCompany\Clientname
and that's something I want to avoid - what belongs together should be
stored together!

Steve

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Nov 4 20:55:49 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.