[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: patch suggestion

From: Branko Čibej <brane_at_xbc.nu>
Date: 2002-11-04 20:29:42 CET

Ich Selbst wrote:

>>"Ich Selbst" <ichselbst@gmx.ch> writes:
>>
>>
>>>I suggest a patch to enable clients to use their own
>>>registry base - that way the settings like proxy, path
>>>to diff and diff3 and the like can be handled on a client
>>>basis.
>>>
>>>
>>A compile time option for this seems of minimal benefit, but maybe I'm
>>just not understanding the scenario here. What is the problem you
>>encountered?
>>
>>
>
>I don't have a problem (this time :)
>
Bah.

> - I just think it better if someone
>uses
>several clients that each client can make its own settings - maybe a client
>wants to use a different diff/diff3 version than another client
>
What's the benefit here?

> or the
>client
>has a built-in diff/diff3 or ...
>
In that case, you won't be able to use the svn_client_diff API at all.

>And since that change belongs to the really small ones I thought it would
>be a good idea.
>
>
It's not a really small change, and your change is wrong because it
totally ignores config files. Besides, making this a compile-time
options means that different clients wouldn't be able to share the same
Subversion libraries. Yuck.

If you want that level of configurability, I suggest designing
client.side hooks/callbacks. But the first step is to finally implement
some kind of context from which the library functios can pull
configuration settings, instead of every function parsing the config all
over again.

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Nov 4 20:30:29 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.