Karl Fogel wrote:
> Vladimir Prus <ghost@cs.msu.su> writes:
>
>>Suppose that svn:externals for a directory did not change. Comment on
>>'svn_wc_edited_externals' read:
>>
>> Directories whose value
>> of the property did not change show the same value in each hash.
>>
>>But they do not! update editors's close_directory method does nothing
>>at all if property has not changed, take a look at
>>libsvn_wc/update_editor.c:797.
>
>
> Ah! Thanks for debugging this, Volodya. I will take a look at the
> patch as soon as I'm done with issue #806. If you have a chance to
> write up a log message, that's great, but I'll start on the patch
> either way.
Actually, the patch breaks all module tests :-(. I have a version which does
not, but need to debug it more and write a test. I hope to post something on Monday.
>>I think I've fixed the "svn up" problem and make_dir problem with the attached patch.
>>The update editor is modified to fill in 'traversal_info' info in all cases.
>>I don't know if there are other editors that needs changing, and I have not written
>>any tests, but I probably can do it, if the general approach is OK.
>
>
> Hmmm. I do have a vague memory that things worked this way for a
> reason, but I can't remember what it was right now (and clearly,
> things aren't exactly "working" anyway). But will investigate in
> depth.
I have another question. It seems that if entire working copy is up-to-date,
then update editors' close_directory will be called only once, with "" as
argument. This means, we cannot traverse external properties on any non-top-level
dirs, unless I'm missing something.
- Volodya
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Nov 1 17:20:42 2002