[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [0.5 PATCH] svn up ignore svn:externals + svn_io_make_dir_recursively bug

From: Karl Fogel <kfogel_at_newton.ch.collab.net>
Date: 2002-11-01 16:40:47 CET

Vladimir Prus <ghost@cs.msu.su> writes:
> Suppose that svn:externals for a directory did not change. Comment on
> 'svn_wc_edited_externals' read:
>
> Directories whose value
> of the property did not change show the same value in each hash.
>
> But they do not! update editors's close_directory method does nothing
> at all if property has not changed, take a look at
> libsvn_wc/update_editor.c:797.

Ah! Thanks for debugging this, Volodya. I will take a look at the
patch as soon as I'm done with issue #806. If you have a chance to
write up a log message, that's great, but I'll start on the patch
either way.

> I think I've fixed the "svn up" problem and make_dir problem with the attached patch.
> The update editor is modified to fill in 'traversal_info' info in all cases.
> I don't know if there are other editors that needs changing, and I have not written
> any tests, but I probably can do it, if the general approach is OK.

Hmmm. I do have a vague memory that things worked this way for a
reason, but I can't remember what it was right now (and clearly,
things aren't exactly "working" anyway). But will investigate in
depth.

Thanks!
-K

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Nov 1 17:13:03 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.