Re: svn commit: rev 3056 - trunk/subversion/libsvn_wc trunk/subversion/libsvn_subr

philip@tigris.org writes:

> Author: philip
> Date: 2002-08-25 05:59:26 -0500 (Sun, 25 Aug 2002)
> New Revision: 3056
>
> * subversion/libsvn_subr/svn_string.c
> (svn_string_first_non_whitespace, svn_stringbuf_first_non_whitespace): Add
> comment about strange return value.
>
> Modified: trunk/subversion/libsvn_subr/svn_string.c
> ==============================================================================
> --- trunk/subversion/libsvn_subr/svn_string.c (original)
> +++ trunk/subversion/libsvn_subr/svn_string.c Sun Aug 25 05:59:29 2002
> @@ -173,7 +173,7 @@
> }
>
> /* if we get here, then the string must be entirely whitespace */
> - return (-1);
> + return (-1); /* ### apr_size_t is unsigned! */
> }
>
> @@ -450,7 +453,7 @@
> }
>
> /* if we get here, then the string must be entirely whitespace */
> - return (-1);
> + return (-1); /* ### apr_size_t is unsigned! */
> }

Should these functions really be returning (apr_size_t)-1? Perhaps
the return type should be apr_ssize_t?

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org