On Wed, Aug 14, 2002 at 07:27:19PM +0100, Philip Martin wrote:
> mark benedetto king <bking@inquira.com> writes:
>
> > Note: this patch may illustrate the need for a client-config callback
> > that gets passed around the system, rather than adding lots of parameters
> > to the various client, wc and ra functions as they become more configuration
> > driven.
>
> In this particular case can't you just replace the boolean no_ignore
> parameter? Isn't passing an empty string the same as no-ignore? I
> don't think we need both.
>
> I suppose we even could get rid of the --no-ignore option, and just
> use --ignore="", but perhaps --no-ignore can be justified as more
> convenient.
>
no_ignore turns off even svn:ignore ignoring, while the ignore parameter
supplements svn:ignore's behaviour. I suppose I could make it a tri-state
thing (where NULL has different meaning than ""), i.e.:
1.) NULL -> no_ignore
2.) "" -> use svn:ignore (special case of (3)
3.) "foo bar" -> add foo and bar to svn:ignore
But I like to avoid tri-state variables for the most part. Do you
think one is warranted here? I, too, am unhappy about the proliferation
of parameters.
--ben
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Aug 14 20:36:08 2002