Re: [PATCH] Implement --ignore and associated config option

mark benedetto king <bking@inquira.com> writes:

> Note: this patch may illustrate the need for a client-config callback
> that gets passed around the system, rather than adding lots of parameters
> to the various client, wc and ra functions as they become more configuration
> driven.

In this particular case can't you just replace the boolean no_ignore
parameter? Isn't passing an empty string the same as no-ignore? I
don't think we need both.

I suppose we even could get rid of the --no-ignore option, and just
use --ignore="", but perhaps --no-ignore can be justified as more
convenient.

>
> Index: subversion/include/svn_wc.h
> ===================================================================
> --- subversion/include/svn_wc.h
> +++ subversion/include/svn_wc.h Mon Aug 12 21:11:46 2002
> @@ -674,6 +674,7 @@
> svn_boolean_t get_all,
> svn_boolean_t strict,
> svn_boolean_t no_ignore,
> + const char *ignore,

Here for example.

> apr_pool_t *pool);
>

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org