Re: [PATCH] Implement --ignore and associated config option

mark benedetto king <bking@Inquira.Com> writes:

> no_ignore turns off even svn:ignore ignoring, while the ignore parameter
> supplements svn:ignore's behaviour. I suppose I could make it a tri-state
> thing (where NULL has different meaning than ""), i.e.:
>
> 1.) NULL -> no_ignore
> 2.) "" -> use svn:ignore (special case of (3)
> 3.) "foo bar" -> add foo and bar to svn:ignore
>
> But I like to avoid tri-state variables for the most part. Do you
> think one is warranted here? I, too, am unhappy about the proliferation
> of parameters.

I'd forgotten about svn:ignore; it does make things more difficult.
Another option is to wrap both the boolean and the char* into an
svn_wc_ignore_t structure. I'm not sure that's any better. Passing
multiple parameters happens already, copyfrom_url/copyfrom_rev comes
to mind.

Perhaps the help text string should change from "set of..." to
"additional...".

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org