Re: svn commit: rev 2485 - trunk/subversion/include trunk/subversion/libsvn_wc trunk/subversion/libsvn_client

Kevin Pilch-Bisson <kevin@pilch-bisson.net> writes:
> > Why would we prohibit deletions? Then our "good" client can't even
> > repair lossage caused by "bad" clients... :-)
>
> Well, all property changes are done via svn_wc_prop_set. Deletions just make
> the value arg NULL. It could be changed to do as you suggest, but I didn't
> really see the need. If we were post-1.0 maybe...

Okay. So the value is NULL to signal deletion. That's how we
implemented deletion internally -- the point is that the user is
deleting the property. It's pretty easy to put a conditional in to
*allow* the deletion of the property even when kind == svn_node_dir.
Just change

   if (kind == svn_node_dir)

to

   if ((kind == svn_node_dir) && (value == NULL))

no?

I mean, we're not talking about some deep theoretical problem here :-).

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jul 12 18:35:40 2002