Re: svn commit: rev 2485 - trunk/subversion/include trunk/subversion/libsvn_wc trunk/subversion/libsvn_client

On Fri, Jul 12, 2002 at 11:24:19AM -0500, Karl Fogel wrote:
> Kevin Pilch-Bisson <kevin@pilch-bisson.net> writes:
> > > Why would we prohibit deletions? Then our "good" client can't even
> > > repair lossage caused by "bad" clients... :-)
> >
> > Well, all property changes are done via svn_wc_prop_set. Deletions just make
> > the value arg NULL. It could be changed to do as you suggest, but I didn't
> > really see the need. If we were post-1.0 maybe...
>
> Okay. So the value is NULL to signal deletion. That's how we
> implemented deletion internally -- the point is that the user is
> deleting the property. It's pretty easy to put a conditional in to
> *allow* the deletion of the property even when kind == svn_node_dir.
> Just change
>
> if (kind == svn_node_dir)
>
> to
>
> if ((kind == svn_node_dir) && (value == NULL))
>
> no?
>
> I mean, we're not talking about some deep theoretical problem here :-).
>
Right. Coming up!

-- 
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Kevin Pilch-Bisson                    http://www.pilch-bisson.net
     "Historically speaking, the presences of wheels in Unix
     has never precluded their reinvention." - Larry Wall
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~