[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 2485 - trunk/subversion/include trunk/subversion/libsvn_wc trunk/subversion/libsvn_client

From: Kevin Pilch-Bisson <kevin_at_pilch-bisson.net>
Date: 2002-07-12 18:24:18 CEST

On Fri, Jul 12, 2002 at 11:13:56AM -0500, Karl Fogel wrote:
> kevin@tigris.org writes:
> > This means that we will get an error if 'svn:executable' is set, edited, or
> > deleted from a directory in the non-recursive case. In the recursive case
> > directories will be silently ignored, and the operation will be performed on
> > the files only. Is this behaviour acceptable to everyone?
>
> Why would we prohibit deletions? Then our "good" client can't even
> repair lossage caused by "bad" clients... :-)

Well, all property changes are done via svn_wc_prop_set. Deletions just make
the value arg NULL. It could be changed to do as you suggest, but I didn't
really see the need. If we were post-1.0 maybe...
>
> If the policy is that the property is not allowed on dirs, then we
> should allow removing it from dirs where it already exists, IMHO.
>
> > Modified: trunk/subversion/libsvn_client/prop_commands.c
> > ==============================================================================
> > --- trunk/subversion/libsvn_client/prop_commands.c (original)
> > +++ trunk/subversion/libsvn_client/prop_commands.c Fri Jul 12 10:47:16 2002
> > if (current_entry->kind == svn_node_dir && current_entry_name)
>
> Gack. I know this isn't your code, but we should parenthesize this
> for clear precedence. (Clear to humans, I mean.)
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
>

-- 
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Kevin Pilch-Bisson                    http://www.pilch-bisson.net
     "Historically speaking, the presences of wheels in Unix
     has never precluded their reinvention." - Larry Wall
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

  • application/pgp-signature attachment: stored
Received on Fri Jul 12 18:27:22 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.