Re: problem arising from early entry deletion

On Mon, Mar 18, 2002 at 03:37:48PM -0600, cmpilato@collab.net wrote:
>...
> Personally, I think the deleted flag need be only a boolean, and then
> I'd rather see svn_wc_entry() and svn_wc_entries_read() just take a
> flag, ALLOW_DELETED, to determine if you were allowed to get deleted
> items back from them. For one thing, changing the arg list would make
> it really easy to find all the places where deleted things be need to
> be used/ignored (compiler is your friend :-), and that that would be
> that. No per-iteration check of the flag.

+1

Sounds much better. Kind of follows the pattern that I once suggested for
creating a "whatis in this directory?" function, with flags to control
whether you got all the files, only versioned files, etc.

Having a flag that includes/excludes deleted items seems to be Goodness.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org