[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: problem arising from early entry deletion

From: <cmpilato_at_collab.net>
Date: 2002-03-18 22:37:48 CET

Karl Fogel <kfogel@newton.ch.collab.net> writes:

> Oh, I also prefer the old way. Ben reminded me that it caused hellish
> amounts of special-casing in libsvn_wc, though.
>
> But, you know, with the new entries interface, it might not be so bad
> anymore. Mike and Ben, you were most familiar with the pain of the
> old code -- would the new entry_t make it cleaner?

No, it wouldn't. But I don't think we'd implement this stuff the same
way this time (which was to add an "existence" multi-state flag and
have all our loops over the entries hash have to pay attention to that
thing).

Personally, I think the deleted flag need be only a boolean, and then
I'd rather see svn_wc_entry() and svn_wc_entries_read() just take a
flag, ALLOW_DELETED, to determine if you were allowed to get deleted
items back from them. For one thing, changing the arg list would make
it really easy to find all the places where deleted things be need to
be used/ignored (compiler is your friend :-), and that that would be
that. No per-iteration check of the flag.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Mar 18 22:40:47 2002

This is an archived mail posted to the Subversion Dev mailing list.