Re: svn commit: rev 1181 - trunk/subversion/bindings/ruby

Garrett Rooney <rooneg@electricjellyfish.net> writes:
> all these files #include "util.h", which has the following prototype
> in it:
>
> svn_client_revision_t svn_ruby_parse_revision (VALUE revOrDate)
>
> only client.c and log.c actually use it though, so perhaps the
> function should be moved out of util.{c, h} to someplace more 'client
> level'. or we could have util.h #include <svn_client.h>, but i've
> always been told that headers that #include other headers is a bad
> thing.

One thing's for sure: the only code that should ever need
svn_client_revision_t is libsvn_client, and any actual clients
implemented on top of libsvn_client.

Hope that helps...

-K

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:37:04 2006