Re: svn commit: rev 1181 - trunk/subversion/bindings/ruby

Karl Fogel <kfogel@newton.ch.collab.net> writes:

> Garrett Rooney <rooneg@electricjellyfish.net> writes:
> > all these files #include "util.h", which has the following prototype
> > in it:
> >
> > svn_client_revision_t svn_ruby_parse_revision (VALUE revOrDate)
> >
> > only client.c and log.c actually use it though, so perhaps the
> > function should be moved out of util.{c, h} to someplace more 'client
> > level'. or we could have util.h #include <svn_client.h>, but i've
> > always been told that headers that #include other headers is a bad
> > thing.
>
> One thing's for sure: the only code that should ever need
> svn_client_revision_t is libsvn_client, and any actual clients
> implemented on top of libsvn_client.

Here are the description of current status:

Some time ago I put RA and Client bindings of log function
to log.c as both code were very similar. Because log.c and
client.c needs Ruby object to svn_client_revision_t
conversion function, I put prototype of it to util.[ch]
which turned out to be a wrong place.

I'm going to put back log bindings to client.c and log.c and
then move svn_ruby_parse_revision to client.c. This will
fix the incorrect dependencies.

-- 
Yoshiki Hayashi
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org