Re: svn commit: rev 1181 - trunk/subversion/bindings/ruby

On Mon, Feb 04, 2002 at 06:39:21PM -0800, Greg Stein wrote:
> On Mon, Feb 04, 2002 at 08:04:28PM -0600, rooneg@tigris.org wrote:
> >...
> > * subversion/bindings/ruby/delta_editor.c
> > * subversion/bindings/ruby/fs.c
> > * subversion/bindings/ruby/fs_node.c
> > * subversion/bindings/ruby/fs_txn.c
> > * subversion/bindings/ruby/repos.c
> > * subversion/bindings/ruby/wc.c
> > add #include <svn_client.h> for definition of svn_client_revision_t.
>
> None of the above files should ever reference svn_client_revision_t. They're
> all at a "lower" level than libsvn_client.
>
> Just what kind of compilation error were you seeing? Something isn't right.

all these files #include "util.h", which has the following prototype
in it:

svn_client_revision_t svn_ruby_parse_revision (VALUE revOrDate)

only client.c and log.c actually use it though, so perhaps the
function should be moved out of util.{c, h} to someplace more 'client
level'. or we could have util.h #include <svn_client.h>, but i've
always been told that headers that #include other headers is a bad
thing.

-garrett

-- 
garrett rooney                     Unix was not designed to stop you from 
rooneg@electricjellyfish.net       doing stupid things, because that would  
http://electricjellyfish.net/      stop you from doing clever things.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org