Greg Stein <gstein@lyra.org> writes:
> Has nothing to do with the compiler, but with the definition of NULL. You're
> using glibc, FreeBSD doesn't. Thus, NULL can be defined very differently. I
> would guess that Linux calls it ((void*)0) or somesuch, while FreeBSD just
> calls it 0. The former doesn't match to integers/characters, while the
> latter does.
Ah, makes perfect sense, thanks.
> >...
> > +svn_error_t *svn_wc_translated_file (svn_stringbuf_t **xlated_p,
> > + svn_stringbuf_t *vfile,
> > + apr_pool_t *pool);
>
> Could these have been "const svn_string_t *" ?
Not really. I started out that way, actually, but the trouble was
most of the callers still want svn_stringbuf_t, and would have had to
convert anyway.
> >...
> > +++ NEW/trunk/subversion/libsvn_wc/diff.c Fri Jan 11 16:38:02 2002
> >...
> > + /* Note that this might be the _second_ time we translate
> > + the file, as svn_wc_text_modified_p() might have used a
> > + tmp translated copy too. But what the heck, diff is
> > + already expensive, translating twice for the sake of code
> > + modularity is liveable. */
> > + SVN_ERR (svn_wc_translated_file (&translated, path,
> > + dir_baton->pool));
> > +
> > + err = diff_cmd (pristine_copy, translated, path,
> > + dir_baton->edit_baton->diff_cmd_baton);
> > +
> > + if (translated != path)
>
> You might want to strengthen the comments in the doc for _translated_file to
> point out that the caller can use pointer comparison for this.
Sure, done.
> > +++ NEW/trunk/subversion/libsvn_wc/util.c Fri Jan 11 16:38:02 2002
> >...
> > +svn_wc_translated_file (svn_stringbuf_t **xlated_p,
> > + svn_stringbuf_t *vfile,
> > + apr_pool_t *pool)
> > +{
> >...
> > + {
> > + /* Because base_file and working file do not use the same eol
> > + style, our only recourse is to convert one of them and do a
> > + byte-for-byte comparison. */
>
> That comment doesn't apply to this function.
Already removed it, but nice catch.
Thanks,
-K
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:56 2006