Re: svn commit: rev 856 - trunk/subversion/include trunk/subversion/libsvn_wc trunk/subversion/libsvn_subr

On Mon, Jan 14, 2002 at 11:13:33AM -0600, Karl Fogel wrote:
> Greg Stein <gstein@lyra.org> writes:
>...
> > >...
> > > +svn_error_t *svn_wc_translated_file (svn_stringbuf_t **xlated_p,
> > > + svn_stringbuf_t *vfile,
> > > + apr_pool_t *pool);
> >
> > Could these have been "const svn_string_t *" ?
>
> Not really. I started out that way, actually, but the trouble was
> most of the callers still want svn_stringbuf_t, and would have had to
> convert anyway.

I'm getting really peeved with svn_stringbuf_t. I'm going to blast a bunch
of them on the plane to Chicago tomorrow. Going to start at the bottom with
the utility functions and work upwards -- it is easier for top-level to pass
an svn_string_t if they have an svn_stringbuf_t (compared to having an
svn_string_t and needing to pass stringbuf).

My first target is the property functions, and bubble up from there.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org