Greg Stein <gstein@lyra.org> writes:
> The existing code for keywords does not scale well at all. If we add a
> single keyword, then we have to go and touch dozens of function calls,
> declarations, etc.
>
> I would *highly* recommend something like:
>
> typedef struct {
> const char *revision;
> const char *author;
> const char *date;
> const char *url;
> /* future keywords go here */
> } svn_keyword_set_t;
Ben originally proposed this too, having (I think) an instinct that it
wouldn't scale well, though he wasn't able to articulate it in that
way at the time. I thought it was a premature optimization, but now I
think you're both right -- we'll probably be adding more keywords
someday, and we'd all curse ourselves if every keyword meant another
explicit parameter to N functions.
+1 (post-facto, as Mike's doing it already).
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:56 2006