Re: [PATCH] apr_getopt_long interface update and interleaving support

Greg Hudson <ghudson@MIT.EDU> writes:
> Oh, right. Same standards as subversion, I take it? It's at the end
> of this message.

Not what I meant to imply -- actually, I don't know exactly what the
APR standards are in that regard. I was just asking for the log
message for my own sake, so it would be easier to comprehend and
commit the patch.

> I did do it; the interface I implemented is exactly what came out of
> that conversation. Perhaps you missed it because long_opts got
> renamed to opts?

Oh! Yes, that's exactly what happened, thanks (doh).

> Incidentally, I have changes to subversion/client/main.c ready once
> this is committed.

Okay -- man, you sure are prepared :-).

I'll do it asap; give me an hour or so to apply, look over, make sure
I understand everything, and all that.

-K

> Log message follows:
> ---
> Simplify apr_getopt_long interface and add support for interleaving.
>
> (apr_getopt_t, apr_initopt): Add "interleave" settable flag and
> "skip_start" and "skip_end" fields to keep track of skipped non-option
> arguments. Change argv to a char ** so that we can permute it.
> (apr_long_option_t): Renamed to apr_option_t.
> (apr_option_t): Rename "val" to "optch" and use for the short option
> name as well as the result. "name" can now be NULL, and a structure
> with an "optch" of 0 now terminates the list.
> (reverse,permute,serr,cerr): New helper functions.
> (apr_getopt_long): Rewrite for simplified interface and for
> interleaved option support.
Received on Sat Oct 21 14:36:15 2006