Re: [PATCH] apr_getopt_long interface update and interleaving support
From: Greg Stein <gstein_at_lyra.org>
Date: 2000-11-25 01:20:47 CET
Looks good overall! I've got a few nits, below.
On Fri, Nov 24, 2000 at 06:46:25PM -0500, Greg Hudson wrote:
Um. I don't think we can do this with argv. I'm surprised that it isn't
Certainly, if we make a copy of the array (of pointers), then we could have
>...
I think the name "apr_option_t" is a bit too generic. The apr_getopt_ prefix
>...
This should be "const char * const * argv". We can make copies internally,
[ there may be some test proggies in apr/test/ that would need changing, too ]
>...
Can we simplify this and make it:
(*os)->skip_start = 1;
By using the other variable, then I need to look back to figure out just
>...
Constify on the above two lines...
>...
The error message is different from the similar error for long options.
Cheers,
-- Greg Stein, http://www.lyra.org/Received on Sat Oct 21 14:36:15 2006 |
This is an archived mail posted to the Subversion Dev mailing list.
This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.