[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] apr_getopt_long interface update and interleaving support

From: Greg Stein <gstein_at_lyra.org>
Date: 2000-11-25 01:24:49 CET

On Fri, Nov 24, 2000 at 03:59:07PM -0600, Karl Fogel wrote:
> Greg Hudson <ghudson@MIT.EDU> writes:
> > Oh, right. Same standards as subversion, I take it? It's at the end
> > of this message.
>
> Not what I meant to imply -- actually, I don't know exactly what the
> APR standards are in that regard. I was just asking for the log
> message for my own sake, so it would be easier to comprehend and
> commit the patch.

Presuming that it will be similar to Apache, then the log message only needs
to describe the change. We don't require details of each function changed
(since that can be seen in the change itself). In essence, the log messages
describes the semantics of the change, the diff provides the detail.

[ which is my personal preference, too; the per-func detail changes
  requested by SVN are a bit much for me, but I deal :-) ]

>...
> > Incidentally, I have changes to subversion/client/main.c ready once
> > this is committed.
>
> Okay -- man, you sure are prepared :-).
>
> I'll do it asap; give me an hour or so to apply, look over, make sure
> I understand everything, and all that.

Karl: I'll defer the commit to you... seems like you raised your hand first
:-)

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
Received on Sat Oct 21 14:36:15 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.