Re: CVS update: subversion/subversion/libsvn_delta xml_output.c

I wrote:
>> What precisely are you anticipating here? I don't see how it would
>> make sense to put anything directly in the pcdata of a prop-delta.

Karl wrote:
> If a prop change includes binary data, how would we encode it as an
> attribute? Or, even if encoding random binary data as XML attribute
> values is legal (which I don't know but could be the case), what if
> the prop change is *huge*? What if someone's sending a GIF image as
> the value of the property?
[and a bunch of other stuff, which I understood but which is also
beside the point]

Right now a prop-delta looks like this:

  <prop-delta>
  <set name="foo">bar</set>
  <delete name="baz"/>
  </prop-delta>

So we already put property values in pcdata, but not the pcdata of the
prop-delta element. (And the pcdata of the set element is already
protected.)

I don't see how it would ever make sense to put anything in the pcdata
of the prop-delta element itself; you wouldn't know which property you
were modifying.
Received on Sat Oct 21 14:36:12 2006