Re: CVS update: subversion/subversion/libsvn_delta xml_output.c

Greg Hudson <ghudson@MIT.EDU> writes:

> Karl committed:
> > (get_to_elem, apply_textdelta): use svn_xml_protect_pcdata when
> > creating text-deltas and prop-deltas.
>
> I think this change should be reverted.
>
> prop-delta elements do not contain meaningful pcdata, just set and
> delete elements.

?? From day 1, the spec has always defined the "value" of a
prop-delta `set' command to be the pcdata inside the tag. So this is
how they're currently implemented inside xml_parse.c. We definitely
need to protect this pcdata from extra newlines!

Now granted, right now properties are very simplistic -- each property
name and value are stored completely in-memory. Someday if we decide
to make them "streamy" like text-deltas, we'll probably want to base64
the property values as well. But that day is not yet near.
Received on Sat Oct 21 14:36:12 2006