[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: CVS update: subversion/subversion/libsvn_delta xml_output.c

From: Karl Fogel <kfogel_at_galois.collab.net>
Date: 2000-10-21 04:18:21 CEST

Greg Hudson <ghudson@MIT.EDU> writes:
> What precisely are you anticipating here? I don't see how it would
> make sense to put anything directly in the pcdata of a prop-delta.

If a prop change includes binary data, how would we encode it as an
attribute? Or, even if encoding random binary data as XML attribute
values is legal (which I don't know but could be the case), what if
the prop change is *huge*? What if someone's sending a GIF image as
the value of the property?

In that case, transmitting it as an attribute has a disadvantage, one
we have worked hard elsewhere to avoid, namely that the value would
have to appear in memory all at once, instead of coming in streamily.
We can only do streamy stuff with pcdata. Attribute values appear in
the argument list to xml callbacks, so they have to all be in memory
(and, come to think of it, the format of those argument lists
prohibits binary data from appearing in a attr value anyway, which
answers my first question).

So that's it in a nutshell.
Received on Sat Oct 21 14:36:12 2006

This is an archived mail posted to the Subversion Dev mailing list.