On Sun, Oct 17, 2010 at 05:24:49AM +0200, Daniel Shahaf wrote:
> Daniel Shahaf wrote on Sun, Oct 17, 2010 at 05:09:37 +0200:
> > Index: subversion/libsvn_wc/copy.c
> > ===================================================================
> > --- subversion/libsvn_wc/copy.c (revision 1023400)
> > +++ subversion/libsvn_wc/copy.c (working copy)
> > @@ -238,6 +238,17 @@ copy_versioned_file(svn_wc__db_t *db,
> > tmpdir_abspath,
> > TRUE, /* recursive */
> > cancel_func, cancel_baton, scratch_pool));
> > +
> > + /* Remove 'read-only' from the copied file. */
> > + {
> > + const svn_string_t *needs_lock;
> > + SVN_ERR(svn_wc__internal_propget(&needs_lock, db, src_abspath,
> > + SVN_PROP_NEEDS_LOCK, scratch_pool,
> > + scratch_pool));
> > + if (needs_lock)
> > + svn_io_set_file_read_write(tmp_dst_abspath, FALSE, scratch_pool);
> > + }
> > +
> > if (tmp_dst_abspath)
> > {
> > svn_skel_t *work_item;
>
> Probably not a good idea to set_file_read_write(tmp_dst_abspath)
> before the check that it's non-NULL. I'll have to look into that.
Thanks for looking into this, Daniel!
Your patch seems to handle copies only. What about locally added files?
Received on 2010-10-17 14:44:44 CEST