[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Code Reviewing

From: David Weintraub <qazwart_at_gmail.com>
Date: Wed, 28 Jan 2009 10:09:22 -0500

A little dilemma here:

Our developers want to do code reviews, but they want to be able to
check in the code before the review, so a tool like Crucible can help
with the code reviews. This means that code checked into Subversion
may not necessarily be good code and should not be in the project.

Several proposals have been talked about: Using a promotion branching
scheme (code would be worked on a "Development Branch" and then merged
to an "Integration Branch" when the code is approved). Using a second
repository (code in the first repository would be reviewed, and when
approved, those changes would be placed in a second repository). Or,
some other scheme to keep the code in Subversion's trunk from getting
contaminated with bad code.

How do you handle code review in Subversion? TeamFoundation has
something called a "shelf" that seems to be able to handle something
like this. Is there a similar concept in Subversion?

David Weintraub
To unsubscribe from this discussion, e-mail: [users-unsubscribe_at_subversion.tigris.org].
Received on 2009-01-28 16:10:23 CET

This is an archived mail posted to the Subversion Users mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.