Re: Code Reviewing

On Wed, Jan 28, 2009 at 10:09 AM, David Weintraub <qazwart_at_gmail.com> wrote:
> A little dilemma here:
>
> Our developers want to do code reviews, but they want to be able to
> check in the code before the review, so a tool like Crucible can help
> with the code reviews. This means that code checked into Subversion
> may not necessarily be good code and should not be in the project.
>
> Several proposals have been talked about: Using a promotion branching
> scheme (code would be worked on a "Development Branch" and then merged
> to an "Integration Branch" when the code is approved). Using a second
> repository (code in the first repository would be reviewed, and when
> approved, those changes would be placed in a second repository). Or,
> some other scheme to keep the code in Subversion's trunk from getting
> contaminated with bad code.
>
> How do you handle code review in Subversion? TeamFoundation has
> something called a "shelf" that seems to be able to handle something
> like this. Is there a similar concept in Subversion?

Not sure if this helps, but have you looked at TeamCity?

http://www.jetbrains.com/teamcity/

Setting that option aside, I wrote a blog post a couple years ago
about how you could approximate shelves using Subversion.

-- 
Thanks
Mark Phippard
http://markphip.blogspot.com/
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=1065&dsMessageId=1063415
To unsubscribe from this discussion, e-mail: [users-unsubscribe_at_subversion.tigris.org].