[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: Code Reviewing

From: Bob Archer <bob.archer_at_amsi.com>
Date: Wed, 28 Jan 2009 10:43:05 -0500

> How do you handle code review in Subversion? TeamFoundation has
> something called a "shelf" that seems to be able to handle something
> like this. Is there a similar concept in Subversion?

Basically doing a "shelf" in TFS is nothing more than creating a private
branch, switching to it, and then committing to that. TFS does all this
for you in the background though.

You could probably create a script or batch that does this for you. Once
the branch ("shelf") has been reviewed it can be merged into trunk. You
could create a batch to also do that too.

I had seen talk somewhere, perhaps on the TortoiseSVN list to create a
"shelf" command that would do this stuff for you in the background.

Another option would be to integrate git into your work flow. Git
basically stores private repositories that you can easily branch and
people can push/pull stuff from one person's repo to another's. Then use
git-svn to finally push this stuff to your svn repository.

What we do, since we are a pretty small shop is just commit the code to
trunk. We have a task in our SCM system for a code review. The dev just
specifics the revision they want reviewed. That is picked up. If all is
ok then there is no merge or anything needed. If there is a problem
changes are just made right to trunk.



To unsubscribe from this discussion, e-mail: [users-unsubscribe_at_subversion.tigris.org].
Received on 2009-01-28 16:45:25 CET

This is an archived mail posted to the Subversion Users mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.