Daniel Shahaf wrote:
>> turns out this was actually due to our pre-commit hook script failing
>> and spitting out some strange output:
>>
>> [Thu Oct 16 17:29:53 2008] @ߚ: Name "OpenSRS::OPENSRS_LOGOUT" used only
>> once: possible typo at @ߚ line 51.
>>
>> Now, my question is:
>> Should this message be a little more clear, perhaps?
>
> What, reading the hex'ed timestamp isn't clear enough already? :-)
nope, it wasn't, unfortunately. If I come across it again, it certainly
will be, however ;)
>> If it said
>> something like 'pre-commit hook script exited non-zero, but we could not
>> parse the output, here's why', it would have been a lot easier to
>> troubleshoot this issue :)
>>
>
> Seems that it's fixed already: in 1.5.3, the code reads:
>
> /* If we got the stderr output okay, try to translate it into UTF-8.
> Ensure there is something sensible in the UTF-8 string regardless. */
[snip code]
Excellent, thanks!
-Jeremy
Received on 2008-10-17 10:36:34 CEST