[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: tools/examples/svnshell.py: bug(?)+fix

From: <kfogel_at_collab.net>
Date: 2005-12-31 03:34:14 CET

Peter Ericson <argblarg@gmail.com> writes:
> Hi, as per instructions at
> http://subversion.tigris.org/project_issues.html I'm posting here
> first, I don't usually follow this list but have just subscribed.
>
> This bug wouldn't usually appear unless user is trying to cat a file
> that is larger than core.SVN_STREAM_CHUNK_SIZE -- for me that's 102400
> bytes.

This looks like a real bug to me, but I don't have the opportunity to
reproduce it right now (I'm in a wireless cafe for a few minutes
only). Can you repost to dev@subversion.tigris.org, with "[PATCH]" in
the subject line, and a log message for the change, as per

   http://subversion.tigris.org/mailing-list-guidelines.html#patches

? I'll bet something this easy to understand gets picked up by somone
pretty quickly.

Thanks,
-Karl

-- 
www.collab.net  <>  CollabNet  |  Distributed Development On Demand
> Index: svnshell.py
> ===================================================================
> --- svnshell.py (revision 17939)
> +++ svnshell.py (working copy)
> @@ -78,6 +78,7 @@
>      stream = fs.file_contents(self.root, catpath)
>      while filelen > core.SVN_STREAM_CHUNK_SIZE:
>        print core.svn_stream_read(stream, int(core.SVN_STREAM_CHUNK_SIZE))
> +      filelen -= core.SVN_STREAM_CHUNK_SIZE
>      print core.svn_stream_read(stream, int(filelen))
> 
>    def do_cd(self, arg):
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: users-help@subversion.tigris.org
> 
-- 
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org
Received on Sat Dec 31 05:05:54 2005

This is an archived mail posted to the Subversion Users mailing list.